anuna-research/ar-edit
1
0
Fork 0
Code Issues Pull requests Projects Packages Wiki Activity Actions

fix(render): absolute concat paths for relative --output #6

Closed
hugooconnor wants to merge 0 commits from refs/pull/6/head into main
pull from: refs/pull/6/head
merge into: anuna-research:main
Conversation 0 Commits - Files changed -
hugooconnor commented 2026-06-21 13:04:53 +00:00 (Migrated from codeberg.org)
Copy link

Bug

ar-edit render <edit> --output out.mp4 (relative path) failed with:

Error: ffmpeg failed: concat failed: Error opening input files: No such file or directory

An absolute --output path worked; only relative paths were affected. play and the TUI dodged it because they render to absolute temp paths.

Root cause

ffmpeg's concat demuxer resolves relative file '...' entries relative to the directory containing the list file, not the process cwd. With a relative --output, the work dir (render.rs render_to_file) and the segment paths were relative, so the filelist held .ar-edit-render-out/segment_0000.mp4. ffmpeg then looked for .ar-edit-render-out/.ar-edit-render-out/segment_0000.mp4 → not found.

Fix

write_concat_list now canonicalizes each existing segment path so entries are always absolute. Nonexistent paths fall back to the original (keeps the existing synthetic-path unit tests passing).

Test

Adds write_concat_list_makes_existing_relative_segments_absolute, which reproduces the relative-cwd scenario and asserts the emitted entry is absolute. Verified end-to-end: relative-output render now produces a correct 4.02s file. Full ar-edit-core suite: 1191 passed.

🤖 Generated with Claude Code

## Bug `ar-edit render <edit> --output out.mp4` (relative path) failed with: ``` Error: ffmpeg failed: concat failed: Error opening input files: No such file or directory ``` An absolute `--output` path worked; only relative paths were affected. `play` and the TUI dodged it because they render to absolute temp paths. ## Root cause ffmpeg's concat demuxer resolves relative `file '...'` entries **relative to the directory containing the list file**, not the process cwd. With a relative `--output`, the work dir (`render.rs` `render_to_file`) and the segment paths were relative, so the filelist held `.ar-edit-render-out/segment_0000.mp4`. ffmpeg then looked for `.ar-edit-render-out/.ar-edit-render-out/segment_0000.mp4` → not found. ## Fix `write_concat_list` now canonicalizes each existing segment path so entries are always absolute. Nonexistent paths fall back to the original (keeps the existing synthetic-path unit tests passing). ## Test Adds `write_concat_list_makes_existing_relative_segments_absolute`, which reproduces the relative-cwd scenario and asserts the emitted entry is absolute. Verified end-to-end: relative-output render now produces a correct 4.02s file. Full `ar-edit-core` suite: 1191 passed. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
anuna-research/ar-edit!6
No description provided.